Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add matrix_assembly! and precompute_nzindex! #172

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

yssamtu
Copy link
Contributor

@yssamtu yssamtu commented Aug 29, 2024

This PR improves matrix assembly by reducing memory footprint, based on my thesis ‘Efficient Algorithm for Large-scale Matrix Assembly’.

@fverdugo fverdugo self-requested a review September 3, 2024 11:41
Copy link
Owner

@fverdugo fverdugo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear @yssamtu

Thanks for this PR. Can you please add some code in test/p_sparse_tests.jl that test your code? you can copy and past existing tests for psparse.

See also my inline comments to this review.

src/p_sparse_matrix.jl Outdated Show resolved Hide resolved
src/p_sparse_matrix.jl Outdated Show resolved Hide resolved
src/sparse_utils.jl Outdated Show resolved Hide resolved
src/p_sparse_matrix.jl Outdated Show resolved Hide resolved
src/p_sparse_matrix.jl Outdated Show resolved Hide resolved
@yssamtu yssamtu requested a review from fverdugo October 30, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants